Messages in this thread | | | Date | Sun, 24 Oct 2021 21:20:39 +0800 | From | kernel test robot <> | Subject | [iwlwifi-next:iwlmei_v7 4/7] drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1257:9: error: too many arguments to function 'iwl_finish_nic_init' |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git iwlmei_v7 head: 4abd0a63acebbb63d1d630043c5ab641ac33e9f7 commit: c7b8fb0250e1854aae7c7d0fff102b4116ed4c8a [4/7] iwlwifi: integrate with iwlmei config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=c7b8fb0250e1854aae7c7d0fff102b4116ed4c8a git remote add iwlwifi-next https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git git fetch --no-tags iwlwifi-next iwlmei_v7 git checkout c7b8fb0250e1854aae7c7d0fff102b4116ed4c8a # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/wireless/intel/iwlwifi/pcie/drv.c: In function 'iwl_pci_probe': >> drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1257:9: error: too many arguments to function 'iwl_finish_nic_init' 1257 | ret = iwl_finish_nic_init(iwl_trans, trans); | ^~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/intel/iwlwifi/pcie/internal.h:22, from drivers/net/wireless/intel/iwlwifi/pcie/drv.c:18: drivers/net/wireless/intel/iwlwifi/iwl-io.h:55:5: note: declared here 55 | int iwl_finish_nic_init(struct iwl_trans *trans); | ^~~~~~~~~~~~~~~~~~~
vim +/iwl_finish_nic_init +1257 drivers/net/wireless/intel/iwlwifi/pcie/drv.c
1219 1220 static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 1221 { 1222 const struct iwl_cfg_trans_params *trans; 1223 const struct iwl_cfg *cfg_7265d __maybe_unused = NULL; 1224 struct iwl_trans *iwl_trans; 1225 struct iwl_trans_pcie *trans_pcie; 1226 int i, ret; 1227 const struct iwl_cfg *cfg; 1228 1229 trans = (void *)(ent->driver_data & ~TRANS_CFG_MARKER); 1230 1231 /* 1232 * This is needed for backwards compatibility with the old 1233 * tables, so we don't need to change all the config structs 1234 * at the same time. The cfg is used to compare with the old 1235 * full cfg structs. 1236 */ 1237 cfg = (void *)(ent->driver_data & ~TRANS_CFG_MARKER); 1238 1239 /* make sure trans is the first element in iwl_cfg */ 1240 BUILD_BUG_ON(offsetof(struct iwl_cfg, trans)); 1241 1242 iwl_trans = iwl_trans_pcie_alloc(pdev, ent, trans); 1243 if (IS_ERR(iwl_trans)) 1244 return PTR_ERR(iwl_trans); 1245 1246 trans_pcie = IWL_TRANS_GET_PCIE_TRANS(iwl_trans); 1247 1248 /* 1249 * Let's try to grab NIC access early here. Sometimes, NICs may 1250 * fail to initialize, and if that happens it's better if we see 1251 * issues early on (and can reprobe, per the logic inside), than 1252 * first trying to load the firmware etc. and potentially only 1253 * detecting any problems when the first interface is brought up. 1254 */ 1255 ret = iwl_pcie_prepare_card_hw(iwl_trans); 1256 if (!ret) { > 1257 ret = iwl_finish_nic_init(iwl_trans, trans); 1258 if (ret) 1259 goto out_free_trans; 1260 if (iwl_trans_grab_nic_access(iwl_trans)) { 1261 /* all good */ 1262 iwl_trans_release_nic_access(iwl_trans); 1263 } else { 1264 ret = -EIO; 1265 goto out_free_trans; 1266 } 1267 } 1268 1269 iwl_trans->hw_rf_id = iwl_read32(iwl_trans, CSR_HW_RF_ID); 1270 1271 for (i = 0; i < ARRAY_SIZE(iwl_dev_info_table); i++) { 1272 const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i]; 1273 if ((dev_info->device == (u16)IWL_CFG_ANY || 1274 dev_info->device == pdev->device) && 1275 (dev_info->subdevice == (u16)IWL_CFG_ANY || 1276 dev_info->subdevice == pdev->subsystem_device) && 1277 (dev_info->mac_type == (u16)IWL_CFG_ANY || 1278 dev_info->mac_type == 1279 CSR_HW_REV_TYPE(iwl_trans->hw_rev)) && 1280 (dev_info->mac_step == (u8)IWL_CFG_ANY || 1281 dev_info->mac_step == 1282 CSR_HW_REV_STEP(iwl_trans->hw_rev)) && 1283 (dev_info->rf_type == (u16)IWL_CFG_ANY || 1284 dev_info->rf_type == 1285 CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id)) && 1286 (dev_info->cdb == IWL_CFG_NO_CDB || 1287 CSR_HW_RFID_IS_CDB(iwl_trans->hw_rf_id)) && 1288 (dev_info->rf_id == (u8)IWL_CFG_ANY || 1289 dev_info->rf_id == 1290 IWL_SUBDEVICE_RF_ID(pdev->subsystem_device)) && 1291 (dev_info->no_160 == (u8)IWL_CFG_ANY || 1292 dev_info->no_160 == 1293 IWL_SUBDEVICE_NO_160(pdev->subsystem_device)) && 1294 (dev_info->cores == (u8)IWL_CFG_ANY || 1295 dev_info->cores == 1296 IWL_SUBDEVICE_CORES(pdev->subsystem_device))) { 1297 iwl_trans->cfg = dev_info->cfg; 1298 iwl_trans->name = dev_info->name; 1299 } 1300 } 1301
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |