lkml.org 
[lkml]   [2021]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH V2] rtw89: fix error function parameter
Date

> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Thursday, October 21, 2021 12:21 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Lv Ruyi <lv.ruyi@zte.com.cn>; Zeal Robot
> <zealci@zte.com.cn>
> Subject: [PATCH V2] rtw89: fix error function parameter
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

I think you can say something about the changes of v2 followed by '---', like

---
v2: fix tabs are converted to spaces

> ---
> drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -757,7 +757,7 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
> else
^^^^^^
I have confirmed this is a tab.

> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> - 1, phy_idx);
> + 0, phy_idx);
> /* SCO compensate FC setting */
> sco_comp = rtw8852a_sco_mapping(central_ch);
> rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1

\
 
 \ /
  Last update: 2021-10-21 07:22    [W:0.057 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site