Messages in this thread | | | Date | Thu, 21 Oct 2021 03:10:41 +0000 | From | CGEL <> | Subject | Re: [PATCH] rtw89: fix error function parameter |
| |
On Thu, Oct 21, 2021 at 01:34:25AM +0000, Pkshih wrote: > > > -----Original Message----- > > From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle > > Valo > > Sent: Wednesday, October 20, 2021 6:04 PM > > To: Pkshih <pkshih@realtek.com> > > Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn; > > linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot > > <zealci@zte.com.cn> > > Subject: Re: [PATCH] rtw89: fix error function parameter > > > > Pkshih <pkshih@realtek.com> writes: > > > > >> -----Original Message----- > > >> From: kvalo=codeaurora.org@mg.codeaurora.org > > >> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle > > >> Valo > > >> Sent: Wednesday, October 20, 2021 4:50 PM > > >> To: cgel.zte@gmail.com > > >> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih > > >> <pkshih@realtek.com>; lv.ruyi@zte.com.cn; > > >> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; > > >> linux-kernel@vger.kernel.org; Zeal Robot > > >> <zealci@zte.com.cn> > > >> Subject: Re: [PATCH] rtw89: fix error function parameter > > >> > > >> cgel.zte@gmail.com wrote: > > >> > > >> > From: Lv Ruyi <lv.ruyi@zte.com.cn> > > >> > > > >> > This patch fixes the following Coccinelle warning: > > >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753: > > >> > WARNING possible condition with no effect (if == else) > > >> > > > >> > Reported-by: Zeal Robot <zealci@zte.com.cn> > > >> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> > > >> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > >> > > >> Failed to apply, please rebase on top of wireless-drivers-next. > > >> > > >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753 > > >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply > > >> error: Did you hand edit your patch? > > >> It does not apply to blobs recorded in its index. > > >> hint: Use 'git am --show-current-patch' to see the failed patch > > >> Applying: rtw89: fix error function parameter > > >> Using index info to reconstruct a base tree... > > >> Patch failed at 0001 rtw89: fix error function parameter > > >> > > >> Patch set to Changes Requested. > > >> > > > > > > I think this is because the patch is translated into spaces instead of tabs, > > > in this and following statements. > > > " if (is_2g)" > > > > Ah, I did wonder why it failed as I didn't see any similar patches. We > > have an item about this in the wiki: > > > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues > > > > I don't know why neither. > > I check the mail header of this patch, the mailer is > "X-Mailer: git-send-email 2.25.1". It should work properly. > > Lv Ruyi, could you help to check what happens? > > -- > Ping-Ke
Thanks for Ping-Ke's suggestion,you are right.The previous patch is translated into spaces instead of tabs,and I will submitt a new correct one.
| |