Messages in this thread Patch in this message | | | From | davidcomponentone@gmail ... | Subject | [PATCH lkdtm] lkdtm: Fix reference preceded by free | Date | Fri, 22 Oct 2021 09:28:32 +0800 |
| |
From: Yang Guang <yang.guang5@zte.com.cn>
The coccinelle check report: ./drivers/misc/lkdtm/heap.c:115:7-11: ERROR: reference preceded by free on line 112 Moving the "kfree(base)" after using place to fix it.
Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn> --- drivers/misc/lkdtm/heap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/lkdtm/heap.c b/drivers/misc/lkdtm/heap.c index 8a92f5a800fa..4c6341e7bdca 100644 --- a/drivers/misc/lkdtm/heap.c +++ b/drivers/misc/lkdtm/heap.c @@ -109,8 +109,6 @@ void lkdtm_READ_AFTER_FREE(void) base[offset] = *val; pr_info("Value in memory before free: %x\n", base[offset]); - kfree(base); - pr_info("Attempting bad read from freed memory\n"); saw = base[offset]; if (saw != *val) { @@ -121,6 +119,7 @@ void lkdtm_READ_AFTER_FREE(void) pr_expected_config_param(CONFIG_INIT_ON_FREE_DEFAULT_ON, "init_on_free"); } + kfree(base); kfree(val); } -- 2.30.2
| |