Messages in this thread | | | Date | Sat, 02 Oct 2021 11:12:26 +0000 | From | Orlando Chamberlain <> | Subject | Re: [PATCHv3] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART |
| |
On Sat, 02 Oct 2021 21:04:30 +1000 "Andy Shevchenko" <andriy.shevchenko@linux.intel.com> wrote:
> You ignoring my Reviewed-by tag. Any reason why?
Sorry, I'm new to this and assumed it needed to be reviewed again after any changes (including to the commit message).
> Besides that you are posting patches as continuation of the thread. > It may be problematic for some tools, like `b4`, although I dunno if > Lee is using such tools.
I'll make a v4 with the reviewed-by line. I'll make it a reply to the first version of the patch, and hopefully that'll be the first place tools like `b4` look.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com> > > --- > > v2->v3: Mention "ICL-N" in commit message. > > drivers/mfd/intel-lpss-pci.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mfd/intel-lpss-pci.c > > b/drivers/mfd/intel-lpss-pci.c index c54d19fb184c..a872b4485eac > > 100644 --- a/drivers/mfd/intel-lpss-pci.c > > +++ b/drivers/mfd/intel-lpss-pci.c > > @@ -253,6 +253,8 @@ static const struct pci_device_id > > intel_lpss_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x34ea), > > (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), > > (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), > > (kernel_ulong_t)&spt_info }, > > + /* ICL-N */ > > + { PCI_VDEVICE(INTEL, 0x38a8), > > (kernel_ulong_t)&bxt_uart_info }, /* TGL-H */ > > { PCI_VDEVICE(INTEL, 0x43a7), > > (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), > > (kernel_ulong_t)&bxt_uart_info }, -- > > 2.33.0 > > > > > > -- > With Best Regards, > Andy Shevchenko > >
--
| |