Messages in this thread Patch in this message | | | Date | Sat, 2 Oct 2021 14:04:30 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCHv3] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART |
| |
On Sat, Oct 02, 2021 at 03:31:07AM +0000, Orlando Chamberlain wrote: > Added 8086:38a8 to the intel_lpss_pci driver. It is an Intel Ice Lake > PCH-N UART controler present on the MacBookPro16,2.
You ignoring my Reviewed-by tag. Any reason why?
Besides that you are posting patches as continuation of the thread. It may be problematic for some tools, like `b4`, although I dunno if Lee is using such tools.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com> > --- > v2->v3: Mention "ICL-N" in commit message. > drivers/mfd/intel-lpss-pci.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c > index c54d19fb184c..a872b4485eac 100644 > --- a/drivers/mfd/intel-lpss-pci.c > +++ b/drivers/mfd/intel-lpss-pci.c > @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = { > { PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info }, > { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info }, > { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info }, > + /* ICL-N */ > + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info }, > /* TGL-H */ > { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info }, > { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info }, > -- > 2.33.0 > >
-- With Best Regards, Andy Shevchenko
| |