Messages in this thread | | | From | Drew Fustini <> | Subject | [PATCH 0/2] ARM: dts: am335x: add rtc system-power-controller | Date | Mon, 18 Oct 2021 15:00:18 -0700 |
| |
Johan pointed out when I submitted "ARM: dts: am335x: Add rtc node as system-power-controller" [1] that mentioning am335x-evm and boneblack in the commit message was incorrect. system-power-controller is already present in am335x-boneblack-common.dtsi and am335x-evm would need the property added directly to the dts file.
These are the dts files that currently include either am335x-bone-common.dtsi or am335x-boneblack-common.dtsi:
am335x-bone.dts am335x-bone-common.dtsi
am335x-boneblack.dts am335x-bone-common.dtsi am335x-boneblack-common.dtsi
am335x-boneblack-wireless.dts am335x-bone-common.dtsi am335x-boneblack-common.dtsi
am335x-bonegreen.dts am335x-bone-common.dtsi
am335x-bonegreen-wireless.dts am335x-bone-common.dtsi
am335x-sancloud-bbe.dts am335x-bone-common.dtsi am335x-boneblack-common.dtsi
am335x-sancloud-bbe-lite.dts am335x-bone-common.dtsi am335x-boneblack-common.dtsi
am335x-boneblack, am335x-boneblack-wireless, am335x-sancloud-bbe and am335x-sancloud-bbe-lite currently get the system-power-controller property from am335x-boneblack-common.dtsi. Moving that property to am335x-bone-common.dtsi would have no change for these boards as they include that dtsi file too.
This change would result in the addition of system-power-controller to bone, bonegreen and bonegreen-wireless. These boards all have PMIC_POWR_EN (ZCZ ball C6) connected to PWR_EN on the TPS65217B PMIC. Thus system-power-controller is a valid property for them too.
In addition to BeagleBone, I have reviewed the TI AM335x eval boards:
am335x-evm.dts should _not_ have the system-power-controller property as the PMIC_POWER_EN is not connected on the TMDXEVM3358 board [2]. The ball would be connected to SLEEP (pin 37) on the TPS65910A3 PMIC but R65 is marked as do not populate.
am335x-evmsk.dts should _not_ have system-power-controller property as PMIC_POWER_EN is not connected on the TMDSSK3358 board [3].
am335x-icev2.dts should have the system-power-controller property as the PMIC_POWER_EN (ZCZ ball C6) is connected to PWRHOLD (pin 1) of the TPS65910A3 PMIC on the TMDSICE3359 board [4].
Cc: Jason Kridner <jkridner@beagleboard.org> Cc: Dave Gerlach <d-gerlach@ti.com> Cc: Keerthy <j-keerthy@ti.com> Cc: Johan Hovold <johan@kernel.org>
[1] https://lore.kernel.org/linux-omap/20211012191311.879838-1-dfustini@baylibre.com/ [2] https://www.ti.com/tool/TMDXEVM3358 [3] https://www.ti.com/tool/TMDSSK3358 [4] https://www.ti.com/tool/TMDSICE3359
Drew Fustini (2): ARM: dts: am335x-boneblack-common: move system-power-controller ARM: dts: am335x-icev2: Add system-power-controller to RTC node
arch/arm/boot/dts/am335x-bone-common.dtsi | 1 + arch/arm/boot/dts/am335x-boneblack-common.dtsi | 4 ---- arch/arm/boot/dts/am335x-icev2.dts | 4 ++++ 3 files changed, 5 insertions(+), 4 deletions(-)
-- 2.27.0
| |