lkml.org 
[lkml]   [2021]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/16] ASoC: cs42l42: Reset and power-down on driver remove()
On Fri, Oct 15, 2021 at 02:36:11PM +0100, Richard Fitzgerald wrote:
> Driver remove() should assert RESET and disable the supplies.
> Previously this assumed that calling pm_runtime_suspend() would result
> in a call to cs42l42_runtime_suspend() to power-down. This isn't
> guaranteed - pm_runtime can be disabled.

> pm_runtime_suspend(&i2c_client->dev);
> pm_runtime_disable(&i2c_client->dev);
>
> + gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
> + regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies), cs42l42->supplies);

Won't this end up with an extra disable of the regulators if they're
already disabled?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-10-15 17:06    [W:0.091 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site