Messages in this thread Patch in this message | | | From | Richard Fitzgerald <> | Subject | [PATCH 08/16] ASoC: cs42l42: Reset and power-down on driver remove() | Date | Fri, 15 Oct 2021 14:36:11 +0100 |
| |
Driver remove() should assert RESET and disable the supplies. Previously this assumed that calling pm_runtime_suspend() would result in a call to cs42l42_runtime_suspend() to power-down. This isn't guaranteed - pm_runtime can be disabled.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Fixes: 2b869e0ea598 ("ASoC: cs42l42: Remove power if the driver is being removed") --- sound/soc/codecs/cs42l42.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 420e16563c45..cf1f68474d21 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -2131,6 +2131,9 @@ static int cs42l42_i2c_remove(struct i2c_client *i2c_client) pm_runtime_suspend(&i2c_client->dev); pm_runtime_disable(&i2c_client->dev); + gpiod_set_value_cansleep(cs42l42->reset_gpio, 0); + regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies), cs42l42->supplies); + return 0; } -- 2.11.0
| |