Messages in this thread Patch in this message | | | From | Qing Wang <> | Subject | [PATCH] most: replace snprintf in show functions with sysfs_emit | Date | Thu, 14 Oct 2021 23:50:10 -0700 |
| |
show() must not use snprintf() when formatting the value to be returned to user space.
Fix the coccicheck warnings: WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: Qing Wang <wangqing@vivo.com> --- drivers/most/core.c | 52 ++++++++++++++++++++++++------------------------- drivers/most/most_usb.c | 4 ++-- 2 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/most/core.c b/drivers/most/core.c index e4412c7..ba12154 100644 --- a/drivers/most/core.c +++ b/drivers/most/core.c @@ -208,7 +208,7 @@ static ssize_t number_of_packet_buffers_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", c->iface->channel_vector[i].num_buffers_packet); } @@ -219,7 +219,7 @@ static ssize_t number_of_stream_buffers_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", c->iface->channel_vector[i].num_buffers_streaming); } @@ -230,7 +230,7 @@ static ssize_t size_of_packet_buffer_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", c->iface->channel_vector[i].buffer_size_packet); } @@ -241,7 +241,7 @@ static ssize_t size_of_stream_buffer_show(struct device *dev, struct most_channel *c = to_channel(dev); unsigned int i = c->channel_id; - return snprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", c->iface->channel_vector[i].buffer_size_streaming); } @@ -251,7 +251,7 @@ static ssize_t channel_starving_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving); + return sysfs_emit(buf, "%d\n", c->is_starving); } static ssize_t set_number_of_buffers_show(struct device *dev, @@ -260,7 +260,7 @@ static ssize_t set_number_of_buffers_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.num_buffers); + return sysfs_emit(buf, "%d\n", c->cfg.num_buffers); } static ssize_t set_buffer_size_show(struct device *dev, @@ -269,7 +269,7 @@ static ssize_t set_buffer_size_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.buffer_size); + return sysfs_emit(buf, "%d\n", c->cfg.buffer_size); } static ssize_t set_direction_show(struct device *dev, @@ -279,10 +279,10 @@ static ssize_t set_direction_show(struct device *dev, struct most_channel *c = to_channel(dev); if (c->cfg.direction & MOST_CH_TX) - return snprintf(buf, PAGE_SIZE, "tx\n"); + return sysfs_emit(buf, "tx\n"); else if (c->cfg.direction & MOST_CH_RX) - return snprintf(buf, PAGE_SIZE, "rx\n"); - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); + return sysfs_emit(buf, "rx\n"); + return sysfs_emit(buf, "unconfigured\n"); } static ssize_t set_datatype_show(struct device *dev, @@ -294,10 +294,10 @@ static ssize_t set_datatype_show(struct device *dev, for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) { if (c->cfg.data_type & ch_data_type[i].most_ch_data_type) - return snprintf(buf, PAGE_SIZE, "%s", + return sysfs_emit(buf, "%s", ch_data_type[i].name); } - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); + return sysfs_emit(buf, "unconfigured\n"); } static ssize_t set_subbuffer_size_show(struct device *dev, @@ -306,7 +306,7 @@ static ssize_t set_subbuffer_size_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.subbuffer_size); + return sysfs_emit(buf, "%d\n", c->cfg.subbuffer_size); } static ssize_t set_packets_per_xact_show(struct device *dev, @@ -315,7 +315,7 @@ static ssize_t set_packets_per_xact_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.packets_per_xact); + return sysfs_emit(buf, "%d\n", c->cfg.packets_per_xact); } static ssize_t set_dbr_size_show(struct device *dev, @@ -323,7 +323,7 @@ static ssize_t set_dbr_size_show(struct device *dev, { struct most_channel *c = to_channel(dev); - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.dbr_size); + return sysfs_emit(buf, "%d\n", c->cfg.dbr_size); } #define to_dev_attr(a) container_of(a, struct device_attribute, attr) @@ -395,7 +395,7 @@ static ssize_t description_show(struct device *dev, { struct most_interface *iface = dev_get_drvdata(dev); - return snprintf(buf, PAGE_SIZE, "%s\n", iface->description); + return sysfs_emit(buf, "%s\n", iface->description); } static ssize_t interface_show(struct device *dev, @@ -406,25 +406,25 @@ static ssize_t interface_show(struct device *dev, switch (iface->interface) { case ITYPE_LOOPBACK: - return snprintf(buf, PAGE_SIZE, "loopback\n"); + return sysfs_emit(buf, "loopback\n"); case ITYPE_I2C: - return snprintf(buf, PAGE_SIZE, "i2c\n"); + return sysfs_emit(buf, "i2c\n"); case ITYPE_I2S: - return snprintf(buf, PAGE_SIZE, "i2s\n"); + return sysfs_emit(buf, "i2s\n"); case ITYPE_TSI: - return snprintf(buf, PAGE_SIZE, "tsi\n"); + return sysfs_emit(buf, "tsi\n"); case ITYPE_HBI: - return snprintf(buf, PAGE_SIZE, "hbi\n"); + return sysfs_emit(buf, "hbi\n"); case ITYPE_MEDIALB_DIM: - return snprintf(buf, PAGE_SIZE, "mlb_dim\n"); + return sysfs_emit(buf, "mlb_dim\n"); case ITYPE_MEDIALB_DIM2: - return snprintf(buf, PAGE_SIZE, "mlb_dim2\n"); + return sysfs_emit(buf, "mlb_dim2\n"); case ITYPE_USB: - return snprintf(buf, PAGE_SIZE, "usb\n"); + return sysfs_emit(buf, "usb\n"); case ITYPE_PCIE: - return snprintf(buf, PAGE_SIZE, "pcie\n"); + return sysfs_emit(buf, "pcie\n"); } - return snprintf(buf, PAGE_SIZE, "unknown\n"); + return sysfs_emit(buf, "unknown\n"); } static DEVICE_ATTR_RO(description); diff --git a/drivers/most/most_usb.c b/drivers/most/most_usb.c index 2640c5b..d3790bd9f 100644 --- a/drivers/most/most_usb.c +++ b/drivers/most/most_usb.c @@ -830,7 +830,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, int err; if (sysfs_streq(name, "arb_address")) - return snprintf(buf, PAGE_SIZE, "%04x\n", dci_obj->reg_addr); + return sysfs_emit(buf, "%04x\n", dci_obj->reg_addr); if (sysfs_streq(name, "arb_value")) reg_addr = dci_obj->reg_addr; @@ -842,7 +842,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, if (err < 0) return err; - return snprintf(buf, PAGE_SIZE, "%04x\n", val); + return sysfs_emit(buf, "%04x\n", val); } static ssize_t value_store(struct device *dev, struct device_attribute *attr, -- 2.7.4
| |