Messages in this thread | | | Date | Fri, 15 Oct 2021 16:24:16 +0800 | From | kernel test robot <> | Subject | [tglx-devel:x86/fpu 74/82] arch/x86/kernel/fpu/xstate.c:1314:14: warning: comparison between pointer and integer |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/fpu head: fbeb78415a1b32f890fa49e4355faa02bb0c0602 commit: 14b0c6c4efcd1654d291d501cca977f3476a5c10 [74/82] x86/fpu: Add sanity checks for XFD config: x86_64-randconfig-a006-20211014 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/commit/?id=14b0c6c4efcd1654d291d501cca977f3476a5c10 git remote add tglx-devel https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git git fetch --no-tags tglx-devel x86/fpu git checkout 14b0c6c4efcd1654d291d501cca977f3476a5c10 # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kernel/fpu/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
arch/x86/kernel/fpu/xstate.c: In function 'xfd_valid': >> arch/x86/kernel/fpu/xstate.c:1314:14: warning: comparison between pointer and integer 1314 | if (fpstate == current->thread.fpu.fpstate->xfd) | ^~
vim +1314 arch/x86/kernel/fpu/xstate.c
1304 1305 #ifdef CONFIG_X86_DEBUG_FPU 1306 static inline bool xfd_valid(struct fpstate *fpstate, u64 mask, bool rstor) 1307 { 1308 u64 xfd = __this_cpu_read(xfd_state); 1309 1310 if (fpstate->xfd == xfd) 1311 return true; 1312 1313 /* For current's fpstate the XFD state must be correct. */ > 1314 if (fpstate == current->thread.fpu.fpstate->xfd) 1315 return false; 1316 1317 /* 1318 * XRSTOR(S) from init_fpstate are always correct as it will just 1319 * bring all components into init state and not read from the 1320 * buffer. XSAVE(S) raises #PF after init. 1321 */ 1322 if (fpstate == &init_fpstate) 1323 return rstor; 1324 1325 /* 1326 * XSAVE(S): clone(), fpu_swap_kvm_fpu() 1327 * XRSTORS(S): fpu_swap_kvm_fpu() 1328 */ 1329 1330 /* Remove XFD disabled states from the mask. */ 1331 mask &= ~xfd; 1332 /* Remove features which are valid in fpstate. */ 1333 mask &= ~fpstate->xfeatures; 1334 1335 /* 1336 * Mask should be zero now which means no loads/stores 1337 * past the end of the register state buffer. 1338 */ 1339 return !mask; 1340 } 1341
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |