Messages in this thread | | | Subject | Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty | From | Larry Finger <> | Date | Tue, 5 Jan 2021 12:09:19 -0600 |
| |
On 1/5/21 5:55 AM, Joe Perches wrote: > On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote: >> On 22:24 Tue 05 Jan 2021, Julian Calaby wrote: >>> Hi Bhaskar, > [] >>> and your change is just making this comment worse. >> really??? Not sure about it. > > I agree with Julian. I'm fairly sure it's worse. > The change you suggest doesn't parse well and is extremely odd. > If you _really_ want to just change this use (and the others), > I repeat his suggestion of "by default".
I agree with Julian and Joe. Your suggested change makes it worse!
To match ALL previous commits/patches for these drivers, the subject should be "rtlwifi: <driver_name>: Fix description of usage of own bit in descriptor"
For all drivers, that comment should be written as: /* By default, a beacon packet will only use the first * descriptor and the own bit may not be cleared by the hardware */
Larry
| |