Messages in this thread | | | Date | Tue, 5 Jan 2021 17:11:46 +0530 | From | Bhaskar Chowdhury <> | Subject | Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty |
| |
On 22:24 Tue 05 Jan 2021, Julian Calaby wrote: >Hi Bhaskar, > >On Tue, Jan 5, 2021 at 9:48 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote: >> >> On 21:33 Tue 05 Jan 2021, Julian Calaby wrote: >> >Hi Bhaskar, >> > >> >On Tue, Jan 5, 2021 at 9:19 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote: >> >> >> >> s/defautly/de-faulty/p >> >> >> >> >> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> >> >> --- >> >> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c >> >> index c948dafa0c80..7d02d8abb4eb 100644 >> >> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c >> >> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c >> >> @@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index) >> >> u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN); >> >> >> >> /*beacon packet will only use the first >> >> - *descriptor defautly,and the own may not >> >> + *descriptor de-faulty,and the own may not >> > >> >Really? "de-faultly" isn't any better than "defaultly" and in fact >> >it's even worse as it breaks up the word "default". >> > >> hey, it was written as "defautly" ...and that was simple spelling mistake .. >> so,corrected it. > >Er, no, that isn't the correct replacement. They're using "default" as >a verb and mean "by default". > >The sentence makes no sense with "de-faulty" there instead. > >Ultimately though the entire comment barely makes sense, so the best >way to fix this spelling mistake is to re-write the entire comment so >it does. I would have suggested a new wording for it, but I don't know
hmmmm make sense...
>enough about what's going on here to parse the rest of it. > >So therefore someone who knows what's going on here needs to fix this
>and your change is just making this comment worse. really??? Not sure about it. > >Thanks, > >-- >Julian Calaby > >Email: julian.calaby@gmail.com >Profile: http://www.google.com/profiles/julian.calaby/ [unhandled content-type:application/pgp-signature] | |