Messages in this thread | | | Subject | Re: [PATCH] cxl: Simplify bool conversion | From | Andrew Donnellan <> | Date | Mon, 1 Feb 2021 12:44:12 +1100 |
| |
On 29/1/21 7:25 pm, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not > needed here > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
Thanks!
> --- > drivers/misc/cxl/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c > index d97a243..c173a5e 100644 > --- a/drivers/misc/cxl/sysfs.c > +++ b/drivers/misc/cxl/sysfs.c > @@ -178,7 +178,7 @@ static ssize_t perst_reloads_same_image_store(struct device *device, > if ((rc != 1) || !(val == 1 || val == 0)) > return -EINVAL; > > - adapter->perst_same_image = (val == 1 ? true : false); > + adapter->perst_same_image = (val == 1); > return count; > } > >
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited
| |