lkml.org 
[lkml]   [2021]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/6] soundwire: qcom: add support to missing transport params
From
Date

> struct qcom_swrm_port_config {
> u8 si;
> u8 off1;
> u8 off2;
> u8 bp_mode;
> + u8 hstart;
> + u8 hstop;
> + u8 word_length;
> + u8 bgp_count;

I couldn't figure out what 'bgp' was and had to search. Not sure how you
came up with this abbreviation of "qcom,ports-block-group-count". Adding
a comment wouldn't hurt.

> + u8 lane_control;

Are you able to use lane_control != 0 ? I thought we were missing stuff
at the bus.c level?

\
 
 \ /
  Last update: 2021-01-29 21:20    [W:0.151 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site