lkml.org 
[lkml]   [2021]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands
From
Date


On 01/02/2021 14:16, Vinod Koul wrote:
>> /* Configure number of retries of a read/write cmd */
>> - ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES);
>> + if (ctrl->version_major == 1 && ctrl->version_minor >= 5 &&
>> + ctrl->version_step >= 1) {
> why not use raw version value?
>
> if (ctrl->raw > 0x10501 )
>
We can do that way as well, but Major Minor seems much clear to readers!

--srini


\
 
 \ /
  Last update: 2021-02-01 16:53    [W:0.156 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site