lkml.org 
[lkml]   [2021]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] kernfs: Remove redundant code
Date
Fix the following coccicheck warnings:

./fs/kernfs/file.c:647:1-3: WARNING: possible condition with no effect
(if == else).

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Suggested-by: Jiapeng Zhong <oswb@linux.alibaba.com>
Signed-off-by: Abaci Team <abaci-bugfix@linux.alibaba.com>
---
fs/kernfs/file.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index c757193..9a74c9d 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -644,11 +644,7 @@ static int kernfs_fop_open(struct inode *inode, struct file *file)
* Both paths of the branch look the same. They're supposed to
* look that way and give @of->mutex different static lockdep keys.
*/
- if (has_mmap)
- mutex_init(&of->mutex);
- else
- mutex_init(&of->mutex);
-
+ mutex_init(&of->mutex);
of->kn = kn;
of->file = file;

--
1.8.3.1
\
 
 \ /
  Last update: 2021-01-28 09:27    [W:0.028 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site