Messages in this thread Patch in this message | | | From | Abaci Team <> | Subject | [PATCH] kernfs: Remove redundant code | Date | Thu, 28 Jan 2021 16:25:32 +0800 |
| |
Fix the following coccicheck warnings:
./fs/kernfs/file.c:647:1-3: WARNING: possible condition with no effect (if == else).
Reported-by: Abaci Robot <abaci@linux.alibaba.com> Suggested-by: Jiapeng Zhong <oswb@linux.alibaba.com> Signed-off-by: Abaci Team <abaci-bugfix@linux.alibaba.com> --- fs/kernfs/file.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c index c757193..9a74c9d 100644 --- a/fs/kernfs/file.c +++ b/fs/kernfs/file.c @@ -644,11 +644,7 @@ static int kernfs_fop_open(struct inode *inode, struct file *file) * Both paths of the branch look the same. They're supposed to * look that way and give @of->mutex different static lockdep keys. */ - if (has_mmap) - mutex_init(&of->mutex); - else - mutex_init(&of->mutex); - + mutex_init(&of->mutex); of->kn = kn; of->file = file; -- 1.8.3.1
| |