Messages in this thread Patch in this message | | | From | Biwen Li <> | Subject | [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace | Date | Wed, 27 Jan 2021 16:58:18 +0800 |
| |
From: Biwen Li <biwen.li@nxp.com>
Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ... [ 45.605239] Unbalanced IRQ 120 wake disable [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 irq_set_irq_wake+0x154/0x1a0 ... [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0 [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0 ... [ 45.742825] Call trace: [ 45.745268] irq_set_irq_wake+0x154/0x1a0 [ 45.749278] ds3232_resume+0x38/0x50
On ls2088ardb: In suspend progress(# echo mem > /sys/power/state), pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend() ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), return -ENXIO, there get "Cannot set wakeup source" in ds3232_suspend().
In resume progress(wakeup by flextimer) dpm_resume_end()->dpm_resume() ->device_resume()->ds3232_resume() ->disable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), there get kernel call trace(Unbalanced IRQ 120 wake disable)
Signed-off-by: Biwen Li <biwen.li@nxp.com> --- Change in v2: - update description
drivers/irqchip/irq-ls-extirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c index 564e6de0bd8e..3c6ed7b4744d 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -65,7 +65,7 @@ static struct irq_chip ls_extirq_chip = { .irq_set_type = ls_extirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, }; static int -- 2.17.1
| |