Messages in this thread | | | Subject | Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0 | From | Tom Rix <> | Date | Wed, 27 Jan 2021 14:00:06 -0800 |
| |
On 1/27/21 1:43 PM, richard.gong@linux.intel.com wrote: > From: Richard Gong <richard.gong@intel.com> > > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which > aligns with the firmware settings.
For fixes, you need to have a 'Fixes: ... ' line in the comment.
This lets folks doing the stable branch know how far back to apply the fix.
For this case, this is likely
Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values")
This should go right above your signoff.
By stand alone patch, this change should be split out from your current
[PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
So the next rev out your patch set will have 7 patches, because 1/6 is being split into two patches.
I would recommend the fix be 1/7, to minimize chance of conflicts merging it with stable.
or
submit the split out fix first.
Tom
> > Signed-off-by: Richard Gong <richard.gong@intel.com> > --- > include/linux/firmware/intel/stratix10-svc-client.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h > index ebc2956..1ffb982 100644 > --- a/include/linux/firmware/intel/stratix10-svc-client.h > +++ b/include/linux/firmware/intel/stratix10-svc-client.h > @@ -51,12 +51,12 @@ > #define SVC_STATUS_NO_SUPPORT 6 > > /* > - * Flag bit for COMMAND_RECONFIG > + * Flag for COMMAND_RECONFIG, in bit number > * > * COMMAND_RECONFIG_FLAG_PARTIAL: > - * Set to FPGA configuration type (full or partial). > + * Set for partial configuration. > */ > -#define COMMAND_RECONFIG_FLAG_PARTIAL 1 > +#define COMMAND_RECONFIG_FLAG_PARTIAL 0 > > /* > * Timeout settings for service clients:
| |