Messages in this thread | | | Date | Tue, 26 Jan 2021 21:23:12 +0530 | From | Sai Prakash Ranjan <> | Subject | Re: [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ |
| |
On 2021-01-26 20:53, Guenter Roeck wrote: > On 1/26/21 7:02 AM, Sai Prakash Ranjan wrote: >> As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1) >> of watchdog control register is wakeup interrupt enable bit and >> not related to bark interrupt at all, BIT(0) is used for that. >> So remove incorrect usage of this bit when supporting bark irq for >> pre-timeout notification. Currently with this bit set and bark >> interrupt specified, pre-timeout notification and/or watchdog >> reset/bite does not occur. >> >> Fixes: 36375491a439 ("watchdog: qcom: support pre-timeout when the >> bark irq is available") >> Cc: stable@vger.kernel.org >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > > Assuming that pretimeout _does_ work with this patch applied, > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> >
Thanks Guenter. Yes I have patchset ready and tested [1] on 4 different SoCs on which pretimeout works with this patch and without this, watchdog functionality would be broken on all those platforms and possibly more(the ones I couldn't get access to) if we add bark irq to the watchdog DT node.
[1] https://lore.kernel.org/patchwork/cover/1371270/
Thanks, Sai
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |