Messages in this thread | | | Subject | Re: [PATCH] scsi_logging: print cdb into new line after opcode | From | Martin Kepplinger <> | Date | Mon, 25 Jan 2021 08:29:21 +0100 |
| |
On 23.01.21 04:09, Martin K. Petersen wrote: > > Ewan, > >>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 >>> 00 >>> >>> Print the cdb into a new line in any case, not only when cmd_len is >>> greater than 16. The above example error will then read: >>> >>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 >>> 28 00 01 c0 09 00 00 00 08 00 >> >> I'd rather we not change this. > > I agree. While the current format is suboptimal, there are lots of > things out there parsing these error messages. >
hi Ewan, hi Martin,
That's totally fine. I had this on my list since Douglas suggested to change this during a discussion back in july and I basically wanted to get opinions: https://lore.kernel.org/linux-scsi/31f1ec62-7047-a34b-fdcb-5ea2a2104292@interlog.com/
thanks, martin
| |