Messages in this thread | | | From | Lukas Bulwahn <> | Date | Thu, 21 Jan 2021 17:22:01 +0100 | Subject | Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal |
| |
On Thu, Jan 21, 2021 at 5:16 PM Sedat Dilek <sedat.dilek@gmail.com> wrote: > > On Thu, Jan 21, 2021 at 5:01 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > > Commit 6c8ad4427f6e ("kbuild: check the minimum compiler version in > > Kconfig") removed ./scripts/clang-version.sh and moved its content to > > ./scripts/cc-version.sh. > > > > Since then, ./scripts/get_maintainer.pl --self-test=patterns complains: > > > > warning: no file matches F: scripts/clang-version.sh > > > > The CLANG/LLVM BUILD SUPPORT section in MAINTAINERS intends to track > > changes in ./scripts/clang-version.sh; as the file is removed, track > > changes in ./scripts/cc-version.sh instead now. > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Good catch, Lukas. > > As a tipp: > Next time you can pass '--subject-prefix="PATCH next-YYYYMMDD"' when > doing 'git format-patch ...' (or whatever you use to generate the > patch). >
Thanks for the hint.
> Cannot say if we can add a "Fixes:" tag with commit hash-id of > "kbuild: check the minimum compiler version in Kconfig" - this missed > that move. > Maybe Masahiro does a respin and can fold this into above commit? > That's not my decision. > > Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> >
...and thanks for the review.
Lukas
| |