Messages in this thread | | | Subject | Re: [PATCH v6 1/2] dt-bindings: iio: accel: Add bmi088 accelerometer bindings | From | Mike Looijmans <> | Date | Thu, 21 Jan 2021 09:46:19 +0100 |
| |
Comments inlined below.
Met vriendelijke groet / kind regards,
Mike Looijmans System Expert
TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands
T: +31 (0) 499 33 69 69 E: mike.looijmans@topicproducts.com W: www.topicproducts.com
Please consider the environment before printing this e-mail On 20-01-2021 19:50, Jonathan Cameron wrote: > On Tue, 19 Jan 2021 13:46:21 +0100 > Mike Looijmans <mike.looijmans@topic.nl> wrote: > >> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU, >> the accelerometer part. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> >> --- >> >> Changes in v6: >> I't been almost a year since the last commit, sorry... > No problem. Happens to us all sometimes! > > One thing inline below. > > Thanks, > > Jonathan > >> Fixed the yaml errors >> Add interrupt, vdd and vddio properties >> >> Changes in v5: >> submit together with driver code as patch series >> >> Changes in v2: >> convert to yaml format >> >> .../bindings/iio/accel/bosch,bmi088.yaml | 55 +++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml >> new file mode 100644 >> index 000000000000..459b9969fd12 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/accel/bosch,bmi088.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bosch BMI088 IMU accelerometer part >> + >> +maintainers: >> + - Mike Looijmans <mike.looijmans@topic.nl> >> + >> +description: | >> + Acceleration part of the IMU sensor with an SPI interface >> + Specifications about the sensor can be found at: >> + https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf >> + >> +properties: >> + compatible: >> + enum: >> + - bosch,bmi088_accel >> + >> + reg: >> + maxItems: 1 >> + >> + vdd-supply: true >> + >> + vddio-supply: true >> + >> + interrupts: >> + minItems: 1 >> + maxItems: 2 >> + description: | >> + Type should be either IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_LEVEL_LOW. >> + The first interrupt listed must be the one connected to the INT1 pin, the >> + second must be the one connected to the INT2 pin. > > What if the board only has the INT2 pin connected? > That's looks to be a valid hardware configuration. > > I'd suggest using interrupt-names to cover this.
Yeah makes sense. The pins have the same functionality, so either one will do.
> >> + >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/irq.h> >> + spi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + bmi088_accel@1 { >> + compatible = "bosch,bmi088_accel"; >> + reg = <1>; >> + spi-max-frequency = <10000000>; >> + interrupt-parent = <&gpio6>; >> + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; >> + }; >> + }; >> +... >
| |