lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/13] opp: Keep track of currently programmed OPP
From
Date
21.01.2021 14:17, Viresh Kumar пишет:
> @@ -1074,15 +1091,18 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
>
> if (!ret) {
> ret = _set_opp_bw(opp_table, opp, dev, false);
> - if (!ret)
> + if (!ret) {
> opp_table->enabled = true;
> + dev_pm_opp_put(old_opp);
> +
> + /* Make sure current_opp doesn't get freed */
> + dev_pm_opp_get(opp);
> + opp_table->current_opp = opp;
> + }
> }

I'm a bit surprised that _set_opp_bw() isn't used similarly to
_set_opp_voltage() in _generic_set_opp_regulator().

I'd expect the BW requirement to be raised before the clock rate goes UP.

\
 
 \ /
  Last update: 2021-01-21 22:47    [W:0.252 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site