lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/13] opp: Allow _generic_set_opp_clk_only() to work for non-freq devices
On 21-01-21, 23:26, Dmitry Osipenko wrote:
> 21.01.2021 14:17, Viresh Kumar пишет:
> > In order to avoid conditional statements at the caller site, this patch
> > updates _generic_set_opp_clk_only() to work for devices that don't
> > change frequency (like power domains, etc.). Return 0 if the clk pointer
> > passed to this routine is not valid.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> ...
>
> Hello Viresh,
>
> Thank you very much for yours effort! I gave a quick test to this series
> and instantly found one small issue in this patch.
>
> > + /* We may reach here for devices which don't change frequency */
> > + if (unlikely(!clk))
>
> I replaced dev_pm_opp_set_voltage() with dev_pm_opp_set_opp() in the
> Tegra PD driver and got a crash, which happens because the above line
> should be:
>
> if (IS_ERR(clk))

Fixed, thanks.

--
viresh

\
 
 \ /
  Last update: 2021-01-22 05:37    [W:0.060 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site