Messages in this thread | | | Date | Fri, 1 Jan 2021 21:55:08 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace disable_irq |
| |
Hi Barry,
On Sat, Jan 02, 2021 at 05:29:02PM +1300, Barry Song wrote: > disable_irq() after request_irq is unsafe as it gives a time gap which > irq can come before disable_irq(). IRQ_NOAUTOEN is the common way to > avoid enabling IRQ due to requesting IRQ.
Actually it is OK for the ISR to fire before the input device is registered, input core allows that.
What I would like to see is to allow passing something like IRQF_DISABLED to request_irq() so that we would not need neither irq_set_status_flags() nor disable_irq().
Thanks.
-- Dmitry
| |