lkml.org 
[lkml]   [2021]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace disable_irq
Date


> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: Saturday, January 2, 2021 6:55 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace
> disable_irq
>
> Hi Barry,

Hi Dmitry,
Thanks for your quick reply.

>
> On Sat, Jan 02, 2021 at 05:29:02PM +1300, Barry Song wrote:
> > disable_irq() after request_irq is unsafe as it gives a time gap which
> > irq can come before disable_irq(). IRQ_NOAUTOEN is the common way to
> > avoid enabling IRQ due to requesting IRQ.
>
> Actually it is OK for the ISR to fire before the input device is
> registered, input core allows that.
>

Yep. probably the only issue left is that the code looks silly.
It enables the interrupt in request_irq() automatically and
disables it immediately. So a better way would be avoiding enabling
the IRQ during request_irq().

> What I would like to see is to allow passing something like
> IRQF_DISABLED to request_irq() so that we would not need neither
> irq_set_status_flags() nor disable_irq().
>

IRQF_DISABLED has been deleted for many years since Linux kernel
doesn't support interrupts enter while an irq handler is running
any more. That flag used to work for forbidding all interrupts
while kernel was running in one hardIRQ to avoid IRQ races for
kernel older than 2.6.32.

Maybe we can invent a new flag like IRQF_NOAUTOEN for request_irq()?
but right now all other drivers are using irq_set_status_flags
(IRQ_NOAUTOEN) since this request flag doesn't exist.

Do you think it is worth to add a new flag to replace many
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq();
in drivers/gpu, i2c, input, media, net, perf, tc, spi, tty,
usb, vfio?

and +Thomas to get his comments as well :-)

> Thanks.
>
> --
> Dmitry

Thanks
Barry

\
 
 \ /
  Last update: 2021-01-02 09:00    [W:0.032 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site