lkml.org 
[lkml]   [2021]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 v2] iommu: use the __iommu_attach_device() directly for deferred attach
> +int iommu_do_deferred_attach(struct device *dev,
> + struct iommu_domain *domain)

I'd remove the "do_" from the name, it doesn't really add any value.

> +{
> + const struct iommu_ops *ops = domain->ops;
> +
> + if (unlikely(ops->is_attach_deferred &&
> + ops->is_attach_deferred(domain, dev)))
> + return __iommu_attach_device(domain, dev);
> +
> + return 0;

Now that everyting is under the static key we don't really need to
bother with the unlikely micro optimization, do we?

> +extern int iommu_do_deferred_attach(struct device *dev,
> + struct iommu_domain *domain);

No need for the extern.

\
 
 \ /
  Last update: 2021-01-19 16:32    [W:0.084 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site