Messages in this thread | | | Date | Tue, 19 Jan 2021 15:26:41 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2 v2] dma-iommu: use static-key to minimize the impact in the fast-path |
| |
On Tue, Jan 19, 2021 at 07:16:15PM +0800, Lianbo Jiang wrote: > +static DEFINE_STATIC_KEY_FALSE(__deferred_attach);
Why the strange underscores? Wouldn't iommu_deferred_attach_enabled be a better name?
> - if (unlikely(iommu_dma_deferred_attach(dev, domain))) > + if (static_branch_unlikely(&__deferred_attach) && > + iommu_dma_deferred_attach(dev, domain))
Also insted of duplicating this logic in three places, maybe rename iommu_dma_deferred_attach to __iommu_dma_deferred_attach and create a small inline wrapper for it?
| |