Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH] power: supply: fix sbs-charger build, needs REGMAP_I2C | Date | Sat, 16 Jan 2021 13:13:10 -0800 |
| |
CHARGER_SBS should select REGMAP_I2C since it uses API(s) that are provided by that Kconfig symbol.
Fixes these errors:
../drivers/power/supply/sbs-charger.c:149:21: error: variable ‘sbs_regmap’ has initializer but incomplete type static const struct regmap_config sbs_regmap = { ../drivers/power/supply/sbs-charger.c:150:3: error: ‘const struct regmap_config’ has no member named ‘reg_bits’ .reg_bits = 8, ../drivers/power/supply/sbs-charger.c:155:23: error: ‘REGMAP_ENDIAN_LITTLE’ undeclared here (not in a function) .val_format_endian = REGMAP_ENDIAN_LITTLE, /* since based on SMBus */ ../drivers/power/supply/sbs-charger.c: In function ‘sbs_probe’: ../drivers/power/supply/sbs-charger.c:183:17: error: implicit declaration of function ‘devm_regmap_init_i2c’; did you mean ‘devm_request_irq’? [-Werror=implicit-function-declaration] chip->regmap = devm_regmap_init_i2c(client, &sbs_regmap); ../drivers/power/supply/sbs-charger.c: At top level: ../drivers/power/supply/sbs-charger.c:149:35: error: storage size of ‘sbs_regmap’ isn’t known static const struct regmap_config sbs_regmap = {
Fixes: feb583e37f8a ("power: supply: add sbs-charger driver") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Sebastian Reichel <sre@kernel.org> Cc: linux-pm@vger.kernel.org Cc: Martin Mokrejs <mmokrejs@fold.natur.cuni.cz> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: nicolassaenzj@gmail.com Cc: Nicolas Saenz Julienne <nicolas.saenz@prodys.net> Cc: Rafael J. Wysocki <rjw@rjwysocki.net> --- Martin, do you want Reported-by: on this?
drivers/power/supply/Kconfig | 1 + 1 file changed, 1 insertion(+)
--- linux-next-20210115.orig/drivers/power/supply/Kconfig +++ linux-next-20210115/drivers/power/supply/Kconfig @@ -229,6 +229,7 @@ config BATTERY_SBS config CHARGER_SBS tristate "SBS Compliant charger" depends on I2C + select REGMAP_I2C help Say Y to include support for SBS compliant battery chargers.
| |