Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH -next] x86/xen: fix 'nopvspin' build error | Date | Fri, 15 Jan 2021 11:11:23 -0800 |
| |
Fix build error in x86/xen/ when PARAVIRT_SPINLOCKS is not enabled.
Fixes this build error:
../arch/x86/xen/smp_hvm.c: In function ‘xen_hvm_smp_init’: ../arch/x86/xen/smp_hvm.c:77:3: error: ‘nopvspin’ undeclared (first use in this function) nopvspin = true;
Fixes: 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: David Woodhouse <dwmw@amazon.co.uk> Cc: Juergen Gross <jgross@suse.com> --- I tried to use IS_ENABLED(CONFIG_PARAVIRT_SPINLOCKS) on the if line and on the nopvspin assignment line but both of those failed for me-- using gcc 7.5.0.
arch/x86/xen/smp_hvm.c | 2 ++ 1 file changed, 2 insertions(+)
--- linux-next-20210115.orig/arch/x86/xen/smp_hvm.c +++ linux-next-20210115/arch/x86/xen/smp_hvm.c @@ -74,7 +74,9 @@ void __init xen_hvm_smp_init(void) smp_ops.cpu_die = xen_hvm_cpu_die; if (!xen_have_vector_callback) { +#ifdef CONFIG_PARAVIRT_SPINLOCKS nopvspin = true; +#endif return; }
| |