lkml.org 
[lkml]   [2021]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/5] soundwire: fix ACK/NAK handling and improve log
Date
The existing code reports a NAK only when ACK=0
This is not aligned with the SoundWire 1.x specifications.

Table 32 in the SoundWire 1.2 specification shows that a Device shall
not set NAK=1 if ACK=1. But Table 33 shows the Combined Response
may very well be NAK=1/ACK=1, e.g. if another Device than the one
addressed reports a parity error.

NAK=1 signals a 'Command_Aborted', regardless of the ACK bit value.

Move the tests for NAK so that the NAK=1/ACK=1 combination is properly
detected according to the specification.

Also, improve the demesg log to get more information for debugging.

Bard Liao (1):
soundwire: bus: add more details to track failed transfers

Pierre-Louis Bossart (4):
soundwire: use consistent format for Slave devID logs
soundwire: cadence: add status in dev_dbg 'State change' log
soundwire: cadence: fix ACK/NAK handling
soundwire: cadence: adjust verbosity in response handling

drivers/soundwire/bus.c | 11 ++++++-----
drivers/soundwire/cadence_master.c | 29 +++++++++++++++--------------
drivers/soundwire/slave.c | 10 ++++------
3 files changed, 25 insertions(+), 25 deletions(-)

--
2.17.1

\
 
 \ /
  Last update: 2021-01-15 06:40    [W:0.067 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site