Messages in this thread Patch in this message | | | From | trix@redhat ... | Subject | [PATCH] EDAC: sb_edac: simplify switch statement | Date | Mon, 7 Sep 2020 08:32:25 -0700 |
| |
From: Tom Rix <trix@redhat.com>
clang static analyzer reports this problem
sb_edac.c:959:2: warning: Undefined or garbage value returned to caller return type; ^~~~~~~~~~~
This is a false positive.
However by initializing the type to DEV_UNKNOWN the 3 case can be removed from the switch, saving a comparison and jump.
Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/edac/sb_edac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index 68f2fe4df333..93daa4297f2e 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c @@ -939,12 +939,9 @@ static enum dev_type sbridge_get_width(struct sbridge_pvt *pvt, u32 mtr) static enum dev_type __ibridge_get_width(u32 mtr) { - enum dev_type type; + enum dev_type type = DEV_UNKNOWN; switch (mtr) { - case 3: - type = DEV_UNKNOWN; - break; case 2: type = DEV_X16; break; -- 2.18.1
| |