Messages in this thread Patch in this message | | | From | Ahmad Fatoum <> | Subject | [PATCH v2] gpio: siox: explicitly support only threaded irqs | Date | Mon, 7 Sep 2020 17:31:35 +0200 |
| |
The gpio-siox driver uses handle_nested_irq() to implement its interrupt support. This is only capable of handling threaded irq actions. For a hardirq action it triggers a NULL pointer oops. (It calls action->thread_fn which is NULL then.)
Prevent registration of a hardirq action by setting gpio_irq_chip::threaded to true.
Cc: u.kleine-koenig@pengutronix.de Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- v1 -> v2: reworded commit message (Uwe) --- drivers/gpio/gpio-siox.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c index 26e1fe092304..f8c5e9fc4bac 100644 --- a/drivers/gpio/gpio-siox.c +++ b/drivers/gpio/gpio-siox.c @@ -245,6 +245,7 @@ static int gpio_siox_probe(struct siox_device *sdevice) girq->chip = &ddata->ichip; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_level_irq; + girq->threaded = true; ret = devm_gpiochip_add_data(dev, &ddata->gchip, NULL); if (ret) -- 2.28.0
| |