Messages in this thread | | | From | linmiaohe <> | Subject | Re: [PATCH v2] mm/mempool: Add 'else' to split mutually exclusive case | Date | Fri, 25 Sep 2020 02:47:58 +0000 |
| |
Andrew Morton <akpm@linux-foundation.org> wrote: > On Thu, 24 Sep 2020 07:16:41 -0400 Miaohe Lin <linmiaohe@huawei.com> wrote: > >> Add else to split mutually exclusive case and avoid some unnecessary check. >> It doesn't seem to change code generation (compiler is smart), but I >> think it helps readability. > > OK, I guess. But the comments are now in the wrong place. >
Many thanks for kindly reply and fix the wrong comments place. Have a good day!
> --- a/mm/mempool.c~mm-mempool-add-else-to-split-mutually-exclusive-case-fix > +++ a/mm/mempool.c > @@ -60,8 +60,8 @@ static void check_element(mempool_t *poo > /* Mempools backed by slab allocator */ > if (pool->free == mempool_free_slab || pool->free == mempool_kfree) { > __check_element(pool, element, ksize(element)); > - /* Mempools backed by page allocator */ > } else if (pool->free == mempool_free_pages) { > + /* Mempools backed by page allocator */ > int order = (int)(long)pool->pool_data; > void *addr = kmap_atomic((struct page *)element); > > @@ -83,8 +83,8 @@ static void poison_element(mempool_t *po > /* Mempools backed by slab allocator */ > if (pool->alloc == mempool_alloc_slab || pool->alloc == mempool_kmalloc) { > __poison_element(element, ksize(element)); > - /* Mempools backed by page allocator */ > } else if (pool->alloc == mempool_alloc_pages) { > + /* Mempools backed by page allocator */ > int order = (int)(long)pool->pool_data; > void *addr = kmap_atomic((struct page *)element); > > _ > >
| |