Messages in this thread Patch in this message | | | From | Gao Xiang <> | Subject | [PATCH v2 1/3] erofs: avoid unnecessary variable `err' | Date | Sat, 19 Sep 2020 15:27:28 +0800 |
| |
variable `err' in z_erofs_submit_queue() isn't useful here, remove it instead.
Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Gao Xiang <hsiangkao@redhat.com> --- no change since v1.
fs/erofs/zdata.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index ac6cb73df192..e43684b23fdd 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -1190,7 +1190,6 @@ static void z_erofs_submit_queue(struct super_block *sb, do { struct page *page; - int err; page = pickup_page_for_submission(pcl, i++, pagepool, MNGD_MAPPING(sbi), @@ -1216,8 +1215,7 @@ static void z_erofs_submit_queue(struct super_block *sb, ++nr_bios; } - err = bio_add_page(bio, page, PAGE_SIZE, 0); - if (err < PAGE_SIZE) + if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) goto submit_bio_retry; last_index = cur; -- 2.18.1
| |