Messages in this thread | | | Subject | Re: [PATCH 21/22] crypto: qce - add check for xts input length equal to zero | From | Stanimir Varbanov <> | Date | Fri, 7 Aug 2020 20:59:04 +0300 |
| |
Hi,
Thanks for the patch!
On 8/7/20 7:20 PM, Andrei Botila wrote: > From: Andrei Botila <andrei.botila@nxp.com> > > Standardize the way input lengths equal to 0 are handled in all skcipher > algorithms. All the algorithms return 0 for input lengths equal to zero. > > Signed-off-by: Andrei Botila <andrei.botila@nxp.com> > --- > drivers/crypto/qce/skcipher.c | 3 +++ > 1 file changed, 3 insertions(+)
Reviewed-by: Stanimir Varbanov <svarbanov@mm-sol.com>
> > diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c > index 5630c5addd28..887fd4dc9b43 100644 > --- a/drivers/crypto/qce/skcipher.c > +++ b/drivers/crypto/qce/skcipher.c > @@ -223,6 +223,9 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) > int keylen; > int ret; > > + if (!req->cryptlen && IS_XTS(rctx->flags)) > + return 0; > + > rctx->flags = tmpl->alg_flags; > rctx->flags |= encrypt ? QCE_ENCRYPT : QCE_DECRYPT; > keylen = IS_XTS(rctx->flags) ? ctx->enc_keylen >> 1 : ctx->enc_keylen; >
-- regards, Stan
| |