Messages in this thread | | | Subject | Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver | From | Dmitry Osipenko <> | Date | Thu, 6 Aug 2020 18:02:34 +0300 |
| |
06.08.2020 10:30, Rajesh Gumasta пишет: > +static int tegra_dma_program_sid(struct tegra_dma_channel *tdc, > + int chan, int stream_id) > +{ > + unsigned int reg_val = tdc_read(tdc, TEGRA_GPCDMA_CHAN_MCSEQ); > + > + reg_val &= ~(TEGRA_GPCDMA_MCSEQ_STREAM_ID_MASK << > + TEGRA_GPCDMA_MCSEQ_STREAM_ID0_SHIFT); > + reg_val &= ~(TEGRA_GPCDMA_MCSEQ_STREAM_ID_MASK << > + TEGRA_GPCDMA_MCSEQ_STREAM_ID1_SHIFT); > + > + reg_val |= (stream_id << TEGRA_GPCDMA_MCSEQ_STREAM_ID0_SHIFT); > + reg_val |= (stream_id << TEGRA_GPCDMA_MCSEQ_STREAM_ID1_SHIFT);
Have you seen my comment to v1 about FIELD_GET/FIELD_PREP?
If you disagree with something, then you should answer with a rationale and not silently ignore review comments.
| |