Messages in this thread | | | Subject | Re: [Patch v2 2/4] dmaengine: tegra: Add Tegra GPC DMA driver | From | Dmitry Osipenko <> | Date | Thu, 6 Aug 2020 17:49:59 +0300 |
| |
06.08.2020 10:30, Rajesh Gumasta пишет: > +static struct dma_async_tx_descriptor *tegra_dma_prep_dma_memset( > + struct dma_chan *dc, dma_addr_t dest, int value, size_t len, > + unsigned long flags) > +{
This looks and reads okay, although the following style of code's formatting is a bit more common for the kernel:
static struct dma_async_tx_descriptor * tegra_dma_prep_dma_memset(struct dma_chan *dc, dma_addr_t dest, int value, size_t len, unsigned long flags)
You could make this small improvement in a v3. Same for all similar cases in the code.
| |