lkml.org 
[lkml]   [2020]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib: Convert test_hexdump.c to KUnit
On Thu, Aug 06, 2020 at 03:14:40PM +0530, Arpitha Raghunandan wrote:
> Converts test lib/test_hexdump.c to KUnit.
> More information about KUnit can be found at
> https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html.
> KUnit provides a common framework for unit tests in the kernel.

...

> - if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) {
> - pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize);
> - pr_err("Result: '%s'\n", real);
> - pr_err("Expect: '%s'\n", test);
> - failed_tests++;
> - }
> + KUNIT_EXPECT_EQ(kunittest, 0, memcmp(test, real, TEST_HEXDUMP_BUF_SIZE));


Ah, can you explain how user will see now what is being expected and what is in
reality in the buffer? I'm not gonna accept such changes without showing in
explicitly that user is not going to suffer of this change.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-08-06 12:06    [W:0.054 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site