Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 6 Aug 2020 12:52:57 +0300 | Subject | Re: [PATCH] lib: Convert test_hexdump.c to KUnit |
| |
On Thu, Aug 6, 2020 at 12:48 PM Arpitha Raghunandan <98.arpi@gmail.com> wrote: > > Converts test lib/test_hexdump.c to KUnit. > More information about KUnit can be found at > https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html. > KUnit provides a common framework for unit tests in the kernel.
> -config TEST_HEXDUMP > - tristate "Test functions located in the hexdump module at runtime"
We have a nice collection of tests starting with TEST_ in the configuration, now it's gone. I'm strongly against this change. Code itself okay, but without addressing above - NAK.
-- With Best Regards, Andy Shevchenko
| |