lkml.org 
[lkml]   [2020]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] ia64: do not typedef struct pal_min_state_area_s
From
Date
On 8/28/20 10:15 PM, Masahiro Yamada wrote:
> Documentation/process/coding-style.rst says:
>
> Please don't use things like ``vps_t``.
> It's a **mistake** to use typedef for structures and pointers.
>
> This commit converts as follows:
>
> struct pal_min_state_area_s -> struct pal_min_state_area
> pal_min_state_area_t -> struct pal_min_state_area
>
> My main motivation for this is to slim down the include directives
> of <asm/mca.h> in the next commit.
>
> Currently, <asm/mca.h> is required to include <asm/pal.h> directly
> or indirectly due to (pal_min_state_area_t *). Otherwise, it would
> have no idea what pal_min_state_area_t is.
>
> Replacing it with (struct pal_min_state_area *) will relax the header
> dependency since it is enough to tell it is a pointer to a structure,
> and to resolve the size of struct pal_min_state_area. It will make
> <asm/mca.h> independent of <asm/pal.h>.
>
> <asm/pal.h> typedef's a lot of structures, but it is trivial to
> convert the others in the same way.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>
> arch/ia64/include/asm/mca.h | 2 +-
> arch/ia64/include/asm/pal.h | 4 ++--
> arch/ia64/include/asm/sal.h | 2 +-
> arch/ia64/kernel/asm-offsets.c | 18 +++++++++---------
> arch/ia64/kernel/mca.c | 4 ++--
> arch/ia64/kernel/mca_drv.c | 2 +-
> 6 files changed, 16 insertions(+), 16 deletions(-)
>


thanks.
--
~Randy

\
 
 \ /
  Last update: 2020-08-29 20:22    [W:0.073 / U:2.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site