lkml.org 
[lkml]   [2020]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] ia64: remove unneeded header includes from <asm/mca.h>
From
Date
On 8/28/20 10:15 PM, Masahiro Yamada wrote:
> <asm/mca.h> includes too many unneeded headers.
>
> This commit cuts off a lot of header includes.
>
> What we need to include are:
>
> - <linux/percpu.h> for DECLARE_PER_CPU(u64, ia64_mca_pal_base)
> - <linux/threads.h> for NR_CPUS
> - <linux/types.h> for u8, u64, size_t, etc.
> - <asm/ptrace.h> for KERNEL_STACK_SIZE
>
> The other header includes are actually unneeded.
>
> <asm/mca.h> previously included 436 headers, and now it includes
> only 138. I confirmed <asm/mca.h> is still self-contained.

Nice!

> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>
> arch/ia64/include/asm/mca.h | 9 +++------
> arch/ia64/kernel/efi.c | 1 +
> arch/ia64/kernel/mca.c | 1 +
> 3 files changed, 5 insertions(+), 6 deletions(-)
>


thanks.
--
~Randy

\
 
 \ /
  Last update: 2020-08-29 20:22    [W:0.076 / U:5.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site