Messages in this thread | | | From | Kajol Jain <> | Subject | [PATCH v6 0/5] powerpc/perf: Add json file support for hv_24x7 core level events | Date | Thu, 27 Aug 2020 18:39:53 +0530 |
| |
Patchset enhance current runtime parameter support. It introduces new fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is used to specify perpkg events.
The "PerCore" and "PerChip" specifies whether its core or chip events. Based on which we can decide which runtime parameter user want to access. Now character '?' can refers different parameter based on user requirement.
Initially, every time we want to add new terms like chip, core, thread etc, we need to create corrsponding fields in pmu_events and event struct. This patchset adds an enum called 'aggr_mode_class' which store all these aggregation like perchip/percore. It also adds new field 'AggregationMode' to capture these terms. Now, if user wants to add any new term, they just need to add it in the enum defined.
This patchset also adds changes of adding new structure called 'json_event' inside jevents.h file to improve the callback prototype inside jevent files. Initially, whenever user want to add new field, they need to update in all function callback which makes it more and more complex with increased number of parmeters. With this change, we just need to add it in new structure 'json_event'. link to the patch: https://lkml.org/lkml/2020/8/25/217
Changelog: v5 -> v6 - Made changes to improve callback prototype inside jevent file by adding new struture 'json_event' as suggested by Andi Kleen.
- Added Reviewd-by tag from Andi Kleen
- Made changes suggested by Jiri Olsa and John garry includes: - Removing jevents.h file. - Some nits like freeing je->event mem, adding typedef for func and not allocating mem for json_event structure. - Added free for each field in json_event as suggested by John Garry. - In real_event function, rather then returning fixed structure pointer, used strcpy to copy event to je->event field.
- Also merge some changes in this patch set from the patch- https://lkml.org/lkml/2020/8/21/222. except nest event change which was using capability of defining metric using other metric.
- Make power side changes as per new struture added.
Link to the previous version patchset: https://lkml.org/lkml/2020/8/16/50
Kajol Jain (5): perf/jevents: Remove jevents.h file perf/jevents: Add new structure to pass json fields. perf jevents: Add support for parsing perchip/percore events perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events
tools/perf/arch/powerpc/util/header.c | 7 +- .../arch/powerpc/power9/nest_metrics.json | 35 ++- tools/perf/pmu-events/jevents.c | 247 +++++++++--------- tools/perf/pmu-events/jevents.h | 23 -- tools/perf/pmu-events/pmu-events.h | 6 + tools/perf/util/metricgroup.c | 5 +- tools/perf/util/metricgroup.h | 3 +- 7 files changed, 166 insertions(+), 160 deletions(-) delete mode 100644 tools/perf/pmu-events/jevents.h
-- 2.26.2
| |