lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] RDMA: error code handling
Date
ocrdma_qp_state_change() returns 1 when new and old state are the same,
however caller is checking using <0

Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index c1751c9a0f62..518687c5e2cb 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -1384,7 +1384,7 @@ int _ocrdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
/* if new and previous states are same hw doesn't need to
* know about it.
*/
- if (status < 0)
+ if (status == 1)
return status;
return ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask);
}
--
2.25.1
\
 
 \ /
  Last update: 2020-08-25 01:45    [W:0.047 / U:2.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site