lkml.org 
[lkml]   [2020]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] ALSA: echoaudio: Fix memory leak in snd_echo_resume()
Date
When restore_dsp_rettings() fails, chip should be freed
just like when init_hw() and request_irq() fails.

Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
sound/pci/echoaudio/echoaudio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index 6aeb99aa2414..2aa183fe5dc1 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -2226,6 +2226,7 @@ static int snd_echo_resume(struct device *dev)
chip->pipe_alloc_mask = pipe_alloc_mask;
if (err < 0) {
kfree(commpage_bak);
+ snd_echo_free(chip);
return err;
}

--
2.17.1
\
 
 \ /
  Last update: 2020-08-10 08:17    [W:0.035 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site