Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 8 Jul 2020 11:44:08 +0300 | Subject | Re: [PATCH v1 3/5] gpio: max77620: Replace interrupt-enable array with bitmap |
| |
On Wed, Jul 8, 2020 at 11:30 AM Dmitry Osipenko <digetx@gmail.com> wrote: > > There is no need to dedicate an array where a bitmap could be used. > Let's replace the interrupt's enable-array with the enable-mask in order > to improve the code a tad.
...
> +#include <linux/bitops.h>
> unsigned int irq_type[MAX77620_GPIO_NR]; > - bool irq_enabled[MAX77620_GPIO_NR]; > + unsigned long irq_enb_mask;
I would rather to move to DECLARE_BITMAP() (the macro is defined in types.h IIRC)
-- With Best Regards, Andy Shevchenko
| |