lkml.org 
[lkml]   [2020]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 4/5] gpio: max77620: Don't handle disabled interrupts
On Wed, Jul 8, 2020 at 11:29 AM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> Check whether GPIO IRQ is enabled before proceeding with handling the
> interrupt request. The interrupt handler now returns IRQ_NONE if none
> of interrupts were handled, which is usually a sign of a problem.

...

> - pending = value;
> + pending = value & gpio->irq_enb_mask;

> + if (!pending)
> + return IRQ_NONE;

for_each_set_bit() should take care of it, no?
(and probably return with IRQ_RETVAL() macro)

> for_each_set_bit(offset, &pending, MAX77620_GPIO_NR) {
> unsigned int virq;

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-07-08 10:47    [W:1.657 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site