lkml.org 
[lkml]   [2020]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] nvme-pci: use standard block status symbolic names to check return value
Date
It's better to use the same symbol as the return to check return value,
and will always work in the unlikely event that the defines are reordered.

Suggested-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
drivers/nvme/host/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 1ac0717..45cb59c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -873,18 +873,18 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
return BLK_STS_IOERR;

ret = nvme_setup_cmd(ns, req, &cmnd);
- if (ret)
+ if (ret != BLK_STS_OK)
return ret;

if (blk_rq_nr_phys_segments(req)) {
ret = nvme_map_data(dev, req, &cmnd);
- if (ret)
+ if (ret != BLK_STS_OK)
goto out_free_cmd;
}

if (blk_integrity_rq(req)) {
ret = nvme_map_metadata(dev, req, &cmnd);
- if (ret)
+ if (ret != BLK_STS_OK)
goto out_unmap_data;
}

--
1.8.3.1
\
 
 \ /
  Last update: 2020-07-08 04:19    [W:0.043 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site