lkml.org 
[lkml]   [2020]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter
On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Do you have a suggestion for an automated replacement which does?
> I'll happily switch over to that.

I guess I'd simply find the unique set of cases that occur and create
a replacement for each manually. A handful of them or so may already
cover the majority of cases. CC'ing Joe since he deals with this sort
of stuff all the time.

Some cannot be handled with replacements, e.g. re-aligning the full
list is required to fit the longer `_iter` -- if you want to cover
those cases too, applying `clang-format` to the initializer may be a
good approach.

Cheers,
Miguel

\
 
 \ /
  Last update: 2020-07-03 07:57    [W:0.111 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site